fix(files): Fix FileInfo['path'] situation#58827
Merged
Conversation
Previously $fileInfo->getPath() and $fileInfo['path'] would return different things. The [] version was not consistent, being sometimes relative and sometimes kind of absolute, and sometimes plenty wrong (like when used from occ commands, because there is no user in session). So this is always returning absolute now. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
leftybournes and
nfebe
and removed request for
a team
Contributor
Author
$path = $mountPoint . $result['path'];
$result['path'] = substr($mountPoint . $result['path'], $rootLength);So there is this version in View::searchCommon, which at least is explicit about what it does. Here |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
CarlSchwan
approved these changes
Mar 10, 2026
icewind1991
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously
$fileInfo->getPath()and$fileInfo['path']would return different things. The[]version was not consistent, being sometimes relative and sometimes kind of absolute, and sometimes plenty wrong (like when used from occ commands, because there is no user in session).So this is always returning absolute now.
Checklist
3. to review, feature component)stable32)AI (if applicable)